doc: add triagers to the table of contents. #39969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
targos
approved these changes
Sep 1, 2021
|
I'd also support just removing the table of contents as GitHub now generates one automatically:
|
Is the GitHub client? |
The website: https://github.com/nodejs/node#readme |
richardlau
approved these changes
Sep 1, 2021
gireeshpunathil
approved these changes
Sep 1, 2021
In case someone doesn't notice this button like me, we should still keep it. |
tniessen
approved these changes
Sep 1, 2021
lpinca
approved these changes
Sep 1, 2021
|
There is a typo in commit title: conents -> contents. |
Sorry. I will be more careful next time. Hope it won't affect landing. |
iam-frankqiu
added
the
author ready
jasnell
approved these changes
Sep 3, 2021
|
Landed in 17098b2ef69c |
I don't know why. But it seems like not landed successfully. |
PR-URL: nodejs#39969 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in 1811396 |
targos
pushed a commit
that referenced
this pull request
Oct 4, 2021
PR-URL: #39969 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we should add
Triagersto thetable of contentsforCollaboratorsandRelease keyshave already in.